Optimize undo spaces lock #620
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis
During undo tablespace truncation in MySQL, when the target undo tablespace has grown significantly large, the
undo_spaces_lock
(a read-write lock) experiences severe contention, as demonstrated belowThe undo_spaces_lock safeguards concurrent access to the following data structures:
Performance Impact:
When the purge coordinator thread holds the undo_spaces_lock in write mode, all DML foreground threads become blocked, resulting in measurable throughput degradation during this period.
Critical Section Analysis:
The purge coordinator thread pool acquires the lock solely to protect:
(Note: It never modifies
undo::spaces::m_spaces
)DML foreground threads require the lock only to ensure: read consistency of
undo::spaces::m_spaces
(Key Insight: No inherent logical conflict exists between these thread types)
Optimization Strategy
Figure 1 - current undo_spaces_lock (Before)

Figure 2 - The optimized undo_spaces_lock (After)
