CI: Fix artifact names + fix project version#34
Merged
myst6re merged 2 commits intomyst6re:masterfrom Jul 27, 2025
Merged
Conversation
Owner
|
Thanks you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately I missed two important fixes since #33
The CI fix is about the artifact names containing a
--in the name, which was there because before we had a target interface ( gui vs cli ), but since we dropped that we had to drop also the naming in the CI.The other fix is I mistakenly forgot to update the
project()version in theCMakeLists.txtfile, which should now be aligned with the current Hyne version. This will fix the.debpackage version ( in both filename and internal package version ).For a comparison feel free to compare my https://github.com/julianxhokaxhiu/hyne/releases/tag/continuous release with yours.