Updated Readme to match what is in CMakePresets.json#39
Open
jbyron1 wants to merge 1 commit intomyst6re:masterfrom
Open
Updated Readme to match what is in CMakePresets.json#39jbyron1 wants to merge 1 commit intomyst6re:masterfrom
jbyron1 wants to merge 1 commit intomyst6re:masterfrom
Conversation
Owner
|
Thanks for the PR! I tested the README on my machine, and ideally the sequence should be: sudo apt install mono-complete
# + install qtgit submodule update --init
cmake --preset=DebugThis will use the CMakePresets file + vcpkg |
Contributor
|
Overall the PR makes sense to me, but I'd prefer if we use the preset approach instead as it would align to what we do on CI as well, hence providing the end user the same build artifacts we product over here on Github. I'll add a suggestion to the PR. But thanks for rising it up! |
Comment on lines
+94
to
+96
| $ mkdir build install | ||
| $ cmake -S . -B build -DCMAKE_INSTALL_PREFIX=install -DCMAKE_BUILD_TYPE=Debug | ||
| $ cmake --build build --config Debug |
Contributor
There was a problem hiding this comment.
Preferring .build and .install as paths as they would be automatically ignored by our .gitignore
Suggested change
| $ mkdir build install | |
| $ cmake -S . -B build -DCMAKE_INSTALL_PREFIX=install -DCMAKE_BUILD_TYPE=Debug | |
| $ cmake --build build --config Debug | |
| $ mkdir .build .install | |
| $ cmake -B .build --preset=Debug -DCMAKE_INSTALL_PREFIX=.install | |
| # Add the following params if you're building for macOS: -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64" -DVCPKG_TARGET_TRIPLET="universal-osx" | |
| $ cmake --build .build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was trying to build from source on linux and was having problems, realized that the instructions seem to have an additional parent directory above the build and install directories that the CMakePresets.json base preset does not have.
I modified the instructions for linux with the commands that worked for me, i assume the same changes would need to be made to the mac instructions, but i do not have a mac to test with.