Make it possible to add system/0 to the scope from the CLI and add info to README#171
Open
dbalatoni13 wants to merge 2 commits intomywalkb:mainfrom
Open
Make it possible to add system/0 to the scope from the CLI and add info to README#171dbalatoni13 wants to merge 2 commits intomywalkb:mainfrom
dbalatoni13 wants to merge 2 commits intomywalkb:mainfrom
Conversation
dbalatoni13
changed the title
dbalatoni13
force-pushed
the
cli-system-bug
branch
from
8b63506 to
e18911b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently not possible to add system/0 to the scope from the CLI because we don't do the same workaround there which is done in the UI (adding "system" to the list of available packages manually when we encounter the "android" package).
We also want to prompt a reboot in this case.
I struggled to build this till I realized that I needed to use a specific commit of libxposed:api, I added this information to the readme.