chore: update blake3 and use new hazmat api#63
Merged
Conversation
TBH I think the code was fine before, but whatever...
…sh_subtree The bug is gone now, and since this is now an official feature of blake3 we rely on their tests
rklaehn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from the now deprecated blake3::guts API to the new public blake3::hazmat api. This allows us to get rid of the iroh-blake3 fork, since functions to hash entire non-root subtrees are now available in the hazmat api.
We can also remove the recursive_hash_subtree fn that was used for some cases where the old guts api was buggy when working with non-zero chunk groups.
With this PR and the inclusion into iroh-blobs, iroh-blake3 would be obsolete: n0-computer/iroh-blake3#10