fix: Community nodes - setting page empty state #15305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…community-nodes-setting-page-empty-state
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeInfo.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeFooter.vue
Outdated
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeFooter.vue
Show resolved
Hide resolved
| @@ -25,6 +25,7 @@ import CommunityNodeDetails from './CommunityNodeDetails.vue'; | |||
| import CommunityNodeInfo from './CommunityNodeInfo.vue'; | |||
| import CommunityNodeDocsLink from './CommunityNodeDocsLink.vue'; | |||
| import CommunityNodeFooter from './CommunityNodeFooter.vue'; | |||
| import { useUsersStore } from '@/stores/users.store'; | |||
There was a problem hiding this comment.
Rule violated: Ensure every PR has unit tests for Vue files
Missing unit tests for the Vue component changes in NodesListPanel.vue
| @@ -36,7 +36,19 @@ const communityNodesStore = useCommunityNodesStore(); | |||
| const uiStore = useUIStore(); | |||
| const settingsStore = useSettingsStore(); | |||
|
|
|||
| const getEmptyStateTitle = computed(() => { | |||
There was a problem hiding this comment.
Rule violated: Ensure every PR has unit tests for Vue files
Missing unit tests for modified Vue component
packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeInfo.vue
Show resolved
Hide resolved
| <N8nText size="small" color="primary" bold> Manage </N8nText> | ||
| </N8nLink> | ||
| <N8nText size="small" color="primary" bold>|</N8nText> | ||
| <div v-if="props.showManage"> |
There was a problem hiding this comment.
Unnecessary wrapper div element that could affect styling. Consider using Vue's template fragment () for conditional rendering without adding extra DOM elements.
| @@ -8,6 +8,7 @@ import { N8nText, N8nLink } from '@n8n/design-system'; | |||
|
|
|||
| export interface Props { | |||
| packageName: string; | |||
| showManage: boolean; | |||
There was a problem hiding this comment.
Rule violated: Ensure every PR has unit tests for Vue files
Missing unit tests for modified Vue component
| @@ -25,6 +25,7 @@ import CommunityNodeDetails from './CommunityNodeDetails.vue'; | |||
| import CommunityNodeInfo from './CommunityNodeInfo.vue'; | |||
| import CommunityNodeDocsLink from './CommunityNodeDocsLink.vue'; | |||
| import CommunityNodeFooter from './CommunityNodeFooter.vue'; | |||
| import { useUsersStore } from '@/stores/users.store'; | |||
There was a problem hiding this comment.
Rule violated: Ensure every PR has unit tests for Vue files
Missing unit tests for the Vue component changes in NodesListPanel.vue
There was a problem hiding this comment.
affects only CommunityNodeFooter, tests added
| @@ -36,7 +36,19 @@ const communityNodesStore = useCommunityNodesStore(); | |||
| const uiStore = useUIStore(); | |||
| const settingsStore = useSettingsStore(); | |||
|
|
|||
| const getEmptyStateTitle = computed(() => { | |||
There was a problem hiding this comment.
Rule violated: Ensure every PR has unit tests for Vue files
Missing unit tests for modified Vue component
There was a problem hiding this comment.
will be addressed in ticket
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
RomanDavydchuk
approved these changes
May 12, 2025
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-2947-community-nodes-setting-page-empty-state
branch
Merged
dana-gill
pushed a commit
that referenced
this pull request
May 12, 2025
|
Got released with |
ozcangungor
pushed a commit
to ozcangungor/n8n
that referenced
this pull request
May 25, 2025
etobella
pushed a commit
to etobella/n8n
that referenced
this pull request
May 25, 2025
Alexandero89
pushed a commit
to Alexandero89/n8n
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
N8N_UNVERIFIED_PACKAGES_ENABLEDfalseRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)