-
Notifications
You must be signed in to change notification settings - Fork 29.3k
fix(Anthropic Chat Model Node): Fix LmChatAnthropic node to work when both thinking is enabled and tools used #16010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Anthropic Chat Model Node): Fix LmChatAnthropic node to work when both thinking is enabled and tools used #16010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
6b9a1b3
to
1ac30db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 3 issues across 6 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai
to give specific feedback.
packages/@n8n/nodes-langchain/nodes/agents/OpenAiAssistant/utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
Workflow Test Results 📊 🔴 2 Failed,
|
Workflow ID | Workflow Name | Reason |
---|---|---|
237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
84 | Matrix:Room:create invite kick leave:RoomMember:ge... | Too Many Requests on node Matrix1 |
⚠️ Warnings (4)
Workflow ID | Workflow Name | Reason |
---|---|---|
35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
✅ All Cypress E2E specs passed |
…micStructuredTool
1ea19d5
to
c1d02c4
Compare
Workflow Test Results 📊 🔴 2 Failed,
|
Workflow ID | Workflow Name | Reason |
---|---|---|
237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
84 | Matrix:Room:create invite kick leave:RoomMember:ge... | Too Many Requests on node Matrix1 |
⚠️ Warnings (3)
Workflow ID | Workflow Name | Reason |
---|---|---|
257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
✅ All Cypress E2E specs passed |
Summary
This PR fixes a problem that occurs when Anthropic models are used with thinking enabled and tools.
The issues is fixed by updating @langchain/antropic to 0.3.21, @langchain/core to 0.3.48
As part of the upgrade, the following changes have been made to adapt to the new versions:
formatToOpenAIAssistantTool
,mcpToolToDynamicTool
,ToolExecutor.node.ts
to acceptTool
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-988/community-issue-anthropic-models-with-enable-thinking-fail-in-ai-agent
Closes #15715
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)