refactor(core): Simplify ExternalSecretsProxy setup and move it to core #16021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 3 issues across 16 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
netroy
force-pushed
the
refactor-secrets-helper
branch
from
93d3891 to
c1dfb82
Compare
n8n-assistant
bot
added
core
netroy
force-pushed
the
refactor-secrets-helper
branch
from
c1dfb82 to
56cf525
Compare
4 tasks
Workflow Test Results 📊 🔴 3 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
| 258 | Agent:auto-fix:openai | Workflow contains 2 deleted data. |
| 84 | Matrix:Room:create invite kick leave:RoomMember:ge... | Too Many Requests on node Matrix1 |
⚠️ Warnings (3)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
| 48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
|
|
netroy
changed the title
ivov
approved these changes
Jun 5, 2025
Workflow Test Results 📊 🔴 3 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
| 52 | Coda:Table:getAllColumns getColumn getAllRows getR... | Too Many Requests on node Coda15 |
| 84 | Matrix:Room:create invite kick leave:RoomMember:ge... | Too Many Requests on node Matrix1 |
⚠️ Warnings (3)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies how we setup SecretsHelper, moves most of it to
n8n-core, and removes all references to it fromn8n-workflow.Extracted out of #15769
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)