feat(ci): testing tuto capabilities in github actions#121
feat(ci): testing tuto capabilities in github actions#121farah-t-trigui wants to merge 2 commits intomainfrom
Conversation
farah-t-trigui
force-pushed
the
feat/automating-tuto-examples-testing
branch
2 times, most recently
from
6ea6d4a to
c7d1a89
Compare
eskenazit
left a comment
eskenazit
left a comment
There was a problem hiding this comment.
see the requested change to be implemented for all steps
| echo "Step 1 endpoint ready!" | ||
| echo "Response: $RESPONSE" | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
If we enter this else case, it means there was an error, so we should probably echo the (likely) invalid response and exit with 1
farah-t-trigui
force-pushed
the
feat/automating-tuto-examples-testing
branch
2 times, most recently
from
243e31a to
e516b02
Compare
farah-t-trigui
force-pushed
the
feat/automating-tuto-examples-testing
branch
12 times, most recently
from
667bf69 to
78388c4
Compare
|
|
||
| - name: Wait for /hello endpoint - My First Capability | ||
| run: | | ||
| sleep 2 |
There was a problem hiding this comment.
Please add comment explaining we need to wait for the framework to start. Also I ma wondering : should not we put the sleep at the end of the Run action rather than the wait one. What do you think ?
There was a problem hiding this comment.
Keeping it in the wait step is better because the run step has one job which is to start the container. The wait step has one job: ensure it's ready
There was a problem hiding this comment.
It means if we setup the run once but perform 70 tests on it, we will wait 70 times for 2 seconds ? If we know we need 2 seconds for the docker to be up and running, it feels more efficient to sleep when we setup it rather than every time we will call it, don't you think ?
| ghcr.io/naftiko/framework:latest \ | ||
| /app/step-1-my-first-capability.yml | ||
|
|
||
| - name: Wait for /hello endpoint - My First Capability |
There was a problem hiding this comment.
"Wait" does not fit semantically speaking, it is more "call" or "consume" the endpoint . Please fix in all related actions.
There was a problem hiding this comment.
okay, will do
| - name: Show logs MCP Server | ||
| if: always() | ||
| run: docker logs mcp_server | ||
|
|
There was a problem hiding this comment.
We are missing an actual test here of the tools here. A list "tools/list" seems to be sufficient for now, please add it =)
farah-t-trigui
force-pushed
the
feat/automating-tuto-examples-testing
branch
2 times, most recently
from
6b48eda to
d3129d7
Compare
farah-t-trigui
force-pushed
the
feat/automating-tuto-examples-testing
branch
from
d3129d7 to
a606d79
Compare
2 participants
A Github Actions workflow dedicated to testing the examples from the tutorial. The goal is to validate that the workflow behaves as expected when following the documented steps and sample configurations in the Wiki.