Skip to content

remove unused env var #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shrugs merged 2 commits into from
Jan 13, 2026
Merged

remove unused env var #1518

shrugs merged 2 commits into from
Jan 13, 2026
+0 −1

Conversation

@lightwalker-eth
Copy link
Member

@lightwalker-eth lightwalker-eth commented Jan 13, 2026

Copilot AI review requested due to automatic review settings January 13, 2026 08:53
@lightwalker-eth lightwalker-eth requested a review from a team as a code owner January 13, 2026 08:53
@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: a0d50b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 13, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
admin.ensnode.io Ready Ready Preview, Comment Jan 13, 2026 5:33pm
ensnode.io Ready Ready Preview, Comment Jan 13, 2026 5:33pm
ensrainbow.io Ready Ready Preview, Comment Jan 13, 2026 5:33pm

Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused NPM_TOKEN environment variable from the GitHub Actions release workflow. The comment on line 72 references a GitHub issue explaining that NODE_AUTH_TOKEN should be used instead of NPM_TOKEN for the changesets action. Since NODE_AUTH_TOKEN is already configured with the NPM token secret, the NPM_TOKEN variable is redundant.

Changes:

  • Removed redundant NPM_TOKEN environment variable from the changesets action step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shrugs
shrugs approved these changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@shrugs shrugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@shrugs shrugs merged commit 45ef9d8 into main Jan 13, 2026
9 of 12 checks passed
@shrugs shrugs deleted the chore/align-npm-auth branch January 13, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@shrugs shrugs shrugs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lightwalker-eth @shrugs