Add sub , mul ,div operators to the clickhouse operators #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinit-j13
force-pushed
the
backend/beam-operators
branch
7 times, most recently
from
4f73914 to
a2efd97
Compare
vinit-j13
changed the title
| Add :: (ClickhouseTable t, ClickhouseNum v) => Column a t v -> Column a t v -> Column a t v | ||
| Sub :: (ClickhouseTable t, ClickhouseNum v) => Column a t v -> Column a t v -> Column a t v | ||
| Mul :: (ClickhouseTable t, ClickhouseNum v) => Column a t v -> Column a t v -> Column a t v | ||
| Div :: (ClickhouseTable t, ClickhouseNum v) => Column a t v -> Column a t v -> Column a t v |
Contributor
There was a problem hiding this comment.
Here, clickhouse div operator always return Float64 type, it can be parsed as Double in Haskell:
Div :: (ClickhouseTable t, ClickhouseNum v) => Column a t v -> Column a t v -> Column a t Double
vinit-j13
force-pushed
the
backend/beam-operators
branch
from
c3cfc22 to
fe44d7f
Compare
roman-bodavskiy
approved these changes
Jan 21, 2026
vinit-j13
force-pushed
the
backend/beam-operators
branch
from
fe44d7f to
025231f
Compare
0utkarsh
approved these changes
Jan 22, 2026
vinit-j13
force-pushed
the
backend/beam-operators
branch
from
025231f to
2923c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
./dev/format-all-files.sh