Marvellous messagepage - Fix lots of bugs and made Home(Message) page for testing#73
Open
Marvellous messagepage - Fix lots of bugs and made Home(Message) page for testing#73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, so this one is a bit long.
Basically in addition to creating message page, there were a lot of fixes in the code base that needed to be done, from footer to header to drawer atoms, they needed to be refactored and "fixed" for future code use.
I think I have done a pretty good job outlining all I have done in the comments throughout the code, so if there is something necessary to be looked at then I am just an email away.
Also some things were shown to be buggy on my environment? don't know if it's just me, though I tried to fix them to the best of my limited knowledge in next (I just started using next for the first time 3 days ago). So I think team members should look at it.