pinctrl: qcom: lpass-lpi: Make audio clock optional #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lpass LPI pinctrl driver previously used clk_bulk to request both "core" and "audio" clocks unconditionally. On some targets such as QCS615, the audio clock is not required and may not be present, which causes probe failures. Refactor the driver to: - request "audio" clock via devm_clk_get_optional() - enable audio clock only if available - adjust error/unwind paths accordingly This allows the driver to work on platforms without an audio clock. Signed-off-by: Le Qi <le.qi@oss.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lpass LPI pinctrl driver previously used clk_bulk to request both "core" and "audio" clocks unconditionally. On some targets such as QCS615, the audio clock is not required and may not be present, which causes probe failures.
Refactor the driver to:
This allows the driver to work on platforms without an audio clock.