Update the integration and add support signals#9
Update the integration and add support signals#9ndt080 wants to merge 8 commits intonanostores:mainfrom
Conversation
|
Wow, super interesting! What will be the difference? |
|
Thanks for the comments you left, I've made some changes to the PR. |
Do you add any public API for end-user? If yes, we need to test them. But I suggest that change
I also need a little explanation why we need this change? Performance? Will signals work for any modern Preact? |
core/types.ts
Outdated
| @@ -0,0 +1,8 @@ | |||
| import type { StoreValue } from 'nanostores'; | |||
There was a problem hiding this comment.
We use types.ts in Nano Stores for type tests.
Can you move it to index.d.ts?
There was a problem hiding this comment.
This file contains common type models for the "useStore" and "useStoreSignal" hooks
There was a problem hiding this comment.
Maybe it is better to put everything in single index.d.ts and index.js. This project is very small to use practices for huge projects.
2 participants
Hi. I updated the integration to use the api provided by preact. In addition, I made an alternative integration option with support for preact signals.
There are no updated tests yet, but there was no time to understand them out.