-
Notifications
You must be signed in to change notification settings - Fork 1
Sourcery refactored master branch #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| uri_parameters_table = soup.select_one('#uri-parameters + table') | ||
| if uri_parameters_table: | ||
| if uri_parameters_table := soup.select_one('#uri-parameters + table'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function parse_page refactored with the following changes:
- Use named expression to simplify assignment and conditional [×3] (
use-named-expression) - Remove redundant pass statement (
remove-redundant-pass) - Remove unnecessary else after guard condition (
remove-unnecessary-else) - Replace f-string with no interpolated values with string [×2] (
remove-redundant-fstring) - Swap if/else branches of if expression to remove negation (
swap-if-expression) - Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
This removes the following comments ( why? ):
# query
| operations.append({ | ||
| 'name': name, | ||
| "request": { | ||
| "method": method, | ||
| "header": headers, | ||
| "body": body, | ||
| "url": { | ||
| "raw": url, | ||
| "protocol": parsed_url.scheme, # "https", | ||
| "host": parsed_url.netloc.split('.'), # ["api", "powerbi", "com"], | ||
| "path": paths, # ["v1.0", "myorg", "groups"], | ||
| "query": query | ||
| operations.append( | ||
| { | ||
| 'name': name, | ||
| "request": { | ||
| "method": method, | ||
| "header": headers, | ||
| "body": body, | ||
| "url": { | ||
| "raw": url, | ||
| "protocol": parsed_url.scheme, # "https", | ||
| "host": parsed_url.netloc.split( | ||
| '.' | ||
| ), # ["api", "powerbi", "com"], | ||
| "path": paths, # ["v1.0", "myorg", "groups"], | ||
| "query": query, | ||
| }, | ||
| "description": f'{description_title}<br>{description_html}', | ||
| }, | ||
| "description": description_title + '<br>' + description_html | ||
| }, | ||
| "response": [], | ||
| '_link': full_href | ||
| }) | ||
| "response": [], | ||
| '_link': full_href, | ||
| } | ||
| ) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function main refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!