Add EIP-1559 (type 2) transaction signing for EVM swaps#71
Open
Add EIP-1559 (type 2) transaction signing for EVM swaps#71
Conversation
signEvmTransaction() now uses type 2 signing when the quote provides maxFeePerGas, falling back to legacy type 0 for gasPrice-only quotes. This avoids overpaying on chains where the base fee drops between quoting and inclusion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signEip1559EvmTransaction()for type 2 EVM transaction signingsignEvmTransaction()now picks type 2 when the quote providesmaxFeePerGas, falling back to legacy type 0 forgasPrice-only quotesmaxFeePerGas,maxPriorityFeePerGas) through to the signing function in the execute handlerWith legacy (type 0), the chain charges the full
gasPrice. With EIP-1559 (type 2), the chain chargesbaseFee + tipand refunds the difference vsmaxFeePerGas. E2e tests on Base showed ~18% savings per gas unit.Test plan
npm test— all 591 unit tests passnpm run test:swap— e2e round-trip (ETH<->USDC on Base) passeseth_getTransactionByHasheffectiveGasPrice<maxFeePerGas(~18% refund per gas unit)🤖 Generated with Claude Code