Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete xfun monkey patch now that xfun 0.56 supports parallel tarball downloads natively. The patch was originally added to parallelize xfun:::download_tarball() for large reverse dependency sets, but is no longer needed with the upstream fix.
Changes:
- Removed
assets/patch-xfun.Rand all related wiring insrc/revdep.rs - Preserved the concurrency setting via
options(xfun.rev_check.download_cores = 50) - Updated performance documentation to reference the native xfun 0.56 parallel download support
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/revdep.rs | Removed xfun patch constants, write function, and all parameter passing through the script generation functions and tests |
| docs/design/performance.md | Updated documentation to reference native xfun 0.56 parallel download support instead of the monkey patch |
| assets/patch-xfun.R | Deleted obsolete monkey patch file |
| CHANGELOG.md | Added maintenance entry documenting removal of the xfun patch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since xfun 0.56 is available on CRAN supporting parallel tarball downloads natively (yihui/xfun#112), this PR:
assets/patch-xfun.Rand all related wiring insrc/revdep.rs(added in Parallelize xfun tarball downloads via monkey patch #127).options(xfun.rev_check.download_cores = 50).Need to test this once xfun 0.56 is synced to P3M.