add fallback mapping for os that are unsupported by rhub#160
Open
ben-schwen wants to merge 1 commit intonanxstats:mainfrom
Open
add fallback mapping for os that are unsupported by rhub#160ben-schwen wants to merge 1 commit intonanxstats:mainfrom
ben-schwen wants to merge 1 commit intonanxstats:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a fallback mechanism to map unsupported Linux distribution versions to their closest supported versions when querying the rhub API. The rhub API currently only supports Debian up to version 12, so this change enables the tool to work with newer Debian versions (like Debian 13) by falling back to Debian 12.
Changes:
- Added
fallback_platformfunction that maps unsupported OS versions to supported ones - Integrated the fallback mapping into the
linux_platformfunction before constructing the platform string
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Great, this fallback makes sense, but let me take a closer look into the exact behavior of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #159
Apparently the rhub API only supports debian up to debian 12
This PR adds a list of fallback version for these cases. Definitely not the most elegant option but it seemed viable.