Skip to content

Refactor#621

Merged
narumincho merged 15 commits intomainfrom
refactor
Mar 19, 2026
Merged

Refactor#621
narumincho merged 15 commits intomainfrom
refactor

Conversation

@narumincho
Copy link
Owner

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a59294724a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 21 to 24
english_name: "English",
native_name: "English",
},
Language {
code: "zh",
english_name: "Chinese",
native_name: "中文",
},
Language {
code: "hi",
english_name: "Hindi",
native_name: "हिन्दी",
},
Language {
code: "es",
english_name: "Spanish",
native_name: "Español",
},
Language {
code: "fr",
english_name: "French",
native_name: "Français",
},
Language {
code: "ar",
english_name: "Arabic",
native_name: "العربية",
},
Language {
code: "bn",
english_name: "Bengali",
native_name: "বাংলা",
},
Language {
code: "pt",
english_name: "Portuguese",
native_name: "Português",
},
Language {
code: "ru",
english_name: "Russian",
native_name: "Русский",
},
Language {
code: "ur",
english_name: "Urdu",
native_name: "اردو",
},
Language {
code: "id",
english_name: "Indonesian",
native_name: "Bahasa Indonesia",
},
Language {
code: "de",
english_name: "German",
native_name: "Deutsch",
},
Language {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore dropped language tags in supported list

Trimming SUPPORTED_LANGUAGES to only en/ja/eo changes behavior in language_from_tag and resolve_language: locale tags that were previously accepted (for example es, zh, fr, etc.) now become unsupported, fall back to another language, and surface the fallback notice path for users whose query string or Accept-Language header uses those codes. This is a user-visible regression introduced by the refactor, not just formatting.

Useful? React with 👍 / 👎.

@narumincho narumincho merged commit db18569 into main Mar 19, 2026
1 check passed
@narumincho narumincho deleted the refactor branch March 19, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant