Skip to content

Conversation

@dzbaker
Copy link
Contributor

@dzbaker dzbaker commented Jan 15, 2026

NASA Docket No. GSC-19,200-1, and identified as "cFS Draco"

Batch update of latest cFS software release

Reflects commit 4589155d61cf2540c335d3495b836fe4677c2b03 from NASA internal development repo

#define PSP_DEBUG(...) PSP_DEBUG_LEV(1, __VA_ARGS__)
#else
/* Debug printfs are not compiled in at all */
#define PSP_DEBUG_LEV(l, ...)

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro PSP_DEBUG_LEV(l,__VA_ARGS__...) is variadic, and hence not allowed.
#else
/* Debug printfs are not compiled in at all */
#define PSP_DEBUG_LEV(l, ...)
#define PSP_DEBUG(...)

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro PSP_DEBUG(__VA_ARGS__...) is variadic, and hence not allowed.
CFE_PSP_MODULE_DECLARE_SIMPLE(endian_api);

/* Note these are not supposed to be exposed publicly but UT needs to access them */
uint8_t CFE_PSP_ENDIAN_INDICATOR;

Check notice

Code scanning / CodeQL

Global could be static Note

The global variable CFE_PSP_ENDIAN_INDICATOR is not accessed outside of cfe_psp_endian_common.c and could be made static.
return (CFE_PSP_ENDIAN_INDICATOR == CFE_PSP_LITTLE_INDICATOR);
}

void CFE_PSP_ReportEndian(uint8 CheckValue)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
*/
#include "cfe_psp_endian.h"

#define ENDIAN_CONVERSION_COMBINE_NAME(ns, f) ns##_##f

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro ENDIAN_CONVERSION_COMBINE_NAME(ns,f) uses token pasting and is not allowed.

/* When compiled with _UNIT_TEST_, this changes the names of the functions
* to allow multiple different implementations to be tested together */
#ifdef _UNIT_TEST_

Check notice

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.
/*
** External Declarations
*/
#ifdef __riscv

Check notice

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.
@jphickey jphickey force-pushed the draco-integration branch 3 times, most recently from c6eac8c to 16a0036 Compare January 22, 2026 22:04
Batch update of latest cFS software release

Reflects commit 4589155d61cf2540c335d3495b836fe4677c2b03 from NASA internal development repo
@jphickey jphickey marked this pull request as ready for review January 22, 2026 22:17
@dzbaker dzbaker merged commit 623fc3e into main Jan 22, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants