Skip to content

GQL-111: Update CMR-GraphQL To Support CMR Changes for 'IsDescribedBy' As a UMM-C/AssociatedDOIs Enumeration #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

dmistry1
Copy link
Contributor

Overview

What is the feature?

Update UMM-C schema version from 1.18.3 to 1.18.4: https://git.earthdata.nasa.gov/projects/EMFD/repos/unified-metadata-model/browse/collection/v1.18.4

What is the Solution?

UMM-C schema added a new enum value "IsDescribedBy" under AssociatedDOIs.

Since AssociatedDOIs is a JSON object in we only need to update the version number.

What areas of the application does this impact?

This only required a single version bump in GQL without any other changes.

Testing

Reproduction steps

  • Environment for testing: local
  • **Collection to test with: local **
  1. Ingest a valid collection draft with this associatedDois:
      "associatedDois": [
        {
          "doi": "Test DOI",
          "title": "Some DOI Title",
          "authority": "test",
          "type": "IsDescribedBy"
        }
      ]
  1. Retrieve published collection and verify the MetadataSpecification version is 1.18.4 and you seen the enum type for associatedDOIs.

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
image

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@dmistry1 dmistry1 requested review from rushgeo and daniel-zamora May 15, 2025 17:41
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e641c79) to head (2f188c8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #163   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         2505      2505           
  Branches       285       285           
=========================================
  Hits          2505      2505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmistry1 dmistry1 requested review from zimzoom and jceaser May 15, 2025 17:51
@dmistry1 dmistry1 merged commit c635e26 into main May 19, 2025
9 checks passed
@dmistry1 dmistry1 deleted the GQL-111 branch May 19, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants