Skip to content

GQL-114: Some collection revisions are returning with errors due to the (umm) returned from CMR being null #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

mandyparson
Copy link
Contributor

Overview

What is the feature?

User is able to access collection in CMR:https://cmr.earthdata.nasa.gov/search/concepts/C2768943270-CDDIS.html
But not in MMT: https://mmt.earthdata.nasa.gov/collections/C2768943270-CDDIS

What is the Solution?

Sometimes, the umm: null. See "revision-id" : 3, on this page: https://cmr.earthdata.nasa.gov/search/collections.umm_json?conceptId=C2768943270-CDDIS&allRevisions=true&pretty=true

Needed to edit the normalizeUmmItem function in order to account for this use case.

What areas of the application does this impact?

Collection.js under concepts

Testing

Reproduction steps

  • **Environment for testing: PROD
  • **Collection to test with: C2768943270-CDDIS and C2799465428-POCLOUD
  1. Point local cmr-graphql to PROD and MAKE SURE THE CHANGE graphql-stack.ts line 41 to 1.18.3 (1.18.4 is not in production yet)
  2. Call only revisions on one of the collections above, they should now return. Commenting out my one line change will reveal the original error.

Attachments

Screenshot 2025-05-21 at 3 54 09 PM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0d9eb46) to head (f038560).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         2508      2509    +1     
  Branches       286       287    +1     
=========================================
+ Hits          2508      2509    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@macrouch
Copy link
Contributor

"Some collections are not selectable on MMT" does not describe the work that was done, and this is not MMT. We need descriptive titles because when we review the history we can understand what (and why) work was done

@eudoroolivares2016 eudoroolivares2016 changed the title GQL-114: Some collections are not selectable on MMT GQL-114: Some collection revisions are returning with errors due to the (umm) returned from CMR being null May 22, 2025
@mandyparson mandyparson merged commit 6fd2d6d into main May 22, 2025
9 checks passed
@mandyparson mandyparson deleted the GQL-114 branch May 22, 2025 17:14
eudoroolivares2016 pushed a commit that referenced this pull request May 22, 2025
…he (umm) returned from CMR being null (#164)

* GQL-114: Some collections are not selectable on MMT

* GQL-114: Addressing feedback

* GQL-114: Adding comment
eudoroolivares2016 pushed a commit that referenced this pull request May 22, 2025
…he (umm) returned from CMR being null (#164)

* GQL-114: Some collections are not selectable on MMT

* GQL-114: Addressing feedback

* GQL-114: Adding comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants