-
Notifications
You must be signed in to change notification settings - Fork 9
GQL-114: Some collection revisions are returning with errors due to the (umm) returned from CMR being null #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 2508 2509 +1
Branches 286 287 +1
=========================================
+ Hits 2508 2509 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
"Some collections are not selectable on MMT" does not describe the work that was done, and this is not MMT. We need descriptive titles because when we review the history we can understand what (and why) work was done |
…he (umm) returned from CMR being null (#164) * GQL-114: Some collections are not selectable on MMT * GQL-114: Addressing feedback * GQL-114: Adding comment
…he (umm) returned from CMR being null (#164) * GQL-114: Some collections are not selectable on MMT * GQL-114: Addressing feedback * GQL-114: Adding comment
Overview
What is the feature?
User is able to access collection in CMR:https://cmr.earthdata.nasa.gov/search/concepts/C2768943270-CDDIS.html
But not in MMT: https://mmt.earthdata.nasa.gov/collections/C2768943270-CDDIS
What is the Solution?
Sometimes, the umm: null. See "revision-id" : 3, on this page: https://cmr.earthdata.nasa.gov/search/collections.umm_json?conceptId=C2768943270-CDDIS&allRevisions=true&pretty=true
Needed to edit the normalizeUmmItem function in order to account for this use case.
What areas of the application does this impact?
Collection.js under concepts
Testing
Reproduction steps
Attachments
Checklist