Allow Request to be extended by changing class name 'Request' to static #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response\Headers lowercases header names.
Before header names were only lowercased when created by fromString.
|
I too would love to see this PR since I'm trying to extend Request as well. +1 |
Solves issue nategood#170: HTTP Header parsing is inconsistent
nategood
requested changes
Dec 15, 2016
composer.json
Outdated
| { | ||
| "name": "nategood/httpful", | ||
| "description": "A Readable, Chainable, REST friendly, PHP HTTP Client", | ||
| "name": "bluehaoran/httpful", |
Owner
There was a problem hiding this comment.
Remove these composer changes for the PR. Thanks.
| */ | ||
| public function offsetExists($offset) | ||
| { | ||
| return isset($this->headers[strtolower($offset)]); |
Owner
There was a problem hiding this comment.
I believe this would be a breaking change. It's one I'm for but I believe we'll need to wait to do this until the next major release.
There was a problem hiding this comment.
It's been three years since the last mayor release, and about one year since the last release. I think it's time for some breaking changes :)
Author
There was a problem hiding this comment.
I have no strong feelings about this one, one way or another.
Author
|
Composer.json rolled back as requested. |
Author
|
Is there anything else we need to do to get this PR over the line? |
Author
|
Replaced by #264 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR because I didn't target Dev last time.
Fixed a typo, and added static dereferencing, allowing Request to be extended (so I could add automatic HMAC signing on send()).