Skip to content

Allow Request to be extended by changing class name 'Request' to static #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluehaoran wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Allow Request to be extended by changing class name 'Request' to static #264

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f8f9717
Fix typo
bluehaoran Nov 26, 2015
0e9f402
Change specific named references to Request class to static (which ge…
bluehaoran Nov 26, 2015
35dbd3a
Merge https://github.com/nategood/httpful
bluehaoran Nov 1, 2016
d58c12a
Version bump.
bluehaoran Nov 1, 2016
fdbbf55
Change package name.
bluehaoran Nov 1, 2016
ca002a5
rollback composer.json for merge
bluehaoran Dec 16, 2016
0f2bd46
Rollback composer.json for pull request
bluehaoran Dec 16, 2016
4e7d373
Revert the last few changes so this repo can exist independantly
bluehaoran May 29, 2017
0e6f28d
Revert libary name.
bluehaoran Oct 17, 2017
c49a8c1
Merge branch 'master' of https://github.com/nategood/httpful into nat…
bluehaoran Oct 17, 2017
7b68a1b
Merge branch 'nategood' into PR
bluehaoran Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Httpful/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* itself very nicely to "chaining". You will see several "alias"
* methods: more readable method definitions that wrap
* their more concise counterparts. You will also notice
* no public constructor. This two adds to the readability
* no public constructor. This too adds to the readability
* and "chainabilty" of the library.
*
* @author Nate Good <me@nategood.com>
Expand Down Expand Up @@ -760,7 +760,7 @@ private static function _initializeDefaults()
// recusion. Do not use this syntax elsewhere.
// It goes against the whole readability
// and transparency idea.
self::$_template = new Request(array('method' => Http::GET));
self::$_template = new static(array('method' => Http::GET));

// This is more like it...
self::$_template
Expand Down Expand Up @@ -811,7 +811,7 @@ public static function init($method = null, $mime = null)
if (!isset(self::$_template))
self::_initializeDefaults();

$request = new Request();
$request = new static();
return $request
->_setDefaults()
->method($method)
Expand Down