Fix apps in monorepo #18
Conversation
jsamr
left a comment
jsamr
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
bun.lockb
Outdated
There was a problem hiding this comment.
Bun looks like an interesting choice. But at the moment we have both yarn.lock and bun.lockdb
Is there any public place where you have discussed this preference?
There was a problem hiding this comment.
I used it out of habit and forgot to remove the generated files. I'll get on it.
stibel
force-pushed
the
@stibel/fix/apps
branch
from
0efc6ac to
ab1eb3b
Compare
apps/website/docusaurus.config.js
Outdated
| trackingID: 'G-CYR1XDV25N', | ||
| anonymizeIP: true | ||
| }, | ||
| // Algolia search disabled - requires appId in Docusaurus v3 |
There was a problem hiding this comment.
Add something like TODO: remove or fix here to help find this place in the future
| const props = reflection.children?.filter( | ||
| (c) => c.kind === ReflectionKind.Property | ||
| (c) => | ||
| (c as any).kindString === 'Property' || c.kind === ReflectionKind.Property |
There was a problem hiding this comment.
not a fan of such a cast, add TODO: comment here
| const methods = reflection.children?.filter( | ||
| (c) => c.kind === ReflectionKind.Method | ||
| (c) => | ||
| (c as any).kindString === 'Method' || c.kind === ReflectionKind.Method |
| <TokenPlain>{reflection.name}</TokenPlain> | ||
| {renderTypeParameters( | ||
| reflection.typeParameter, | ||
| (reflection as any).typeParameter || |
There was a problem hiding this comment.
here and throughout this file as well
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/migrate-render-html-with-history #18 +/- ##
==========================================================================
- Coverage 99.30% 98.65% -0.66%
==========================================================================
Files 57 140 +83
Lines 1153 2076 +923
Branches 315 636 +321
==========================================================================
+ Hits 1145 2048 +903
- Misses 8 27 +19
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5ZYSZ3K
merged commit 9e12a16
into
native-html:chore/migrate-render-html-with-history
3 participants
No description provided.