-
Notifications
You must be signed in to change notification settings - Fork 7
Fix website build after migration #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wjkg
wants to merge
21
commits into
native-html:chore/migrate-render-html-with-history
Choose a base branch
from
wjkg:fix/doc-build
base: chore/migrate-render-html-with-history
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix website build after migration #21
wjkg
wants to merge
21
commits into
native-html:chore/migrate-render-html-with-history
from
wjkg:fix/doc-build
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/migrate-render-html-with-history #21 +/- ##
==========================================================================
- Coverage 99.30% 98.65% -0.66%
==========================================================================
Files 57 140 +83
Lines 1153 2076 +923
Branches 315 634 +319
==========================================================================
+ Hits 1145 2048 +903
- Misses 8 27 +19
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: rebase once
@stibel/fix/appsis mergedFixes remaining build errors in
@doc/*andapps/websitepackages:@doc/mdx-gen-clitscin@doc/pagessimilar to Dependency upgrade fixes #17@doc/mdx-gen-cli:react-reconciler@aliases that need@docusaurus/preset-classicto be imported in the projectdata-flow.svgfiles — instead of replicating the extra build step from the original repository, the optimized version cleared of Inkscape metadata is committed in the target directories. (The copy script could be restored in the future if needed, but I omitted it for simplicity, seeing as there's only one image for now)