ShopDetailCardView: 2-column layout with description#37
Merged
dadachi merged 2 commits intosubstrate-v2from Apr 28, 2026
Merged
ShopDetailCardView: 2-column layout with description#37dadachi merged 2 commits intosubstrate-v2from
dadachi merged 2 commits intosubstrate-v2from
Conversation
Mirror iOS ItemTagListCardView's 2-column HStack pattern in
ShopDetailCardView so each item-tag row in ShopDetailView surfaces the
description alongside the name.
Layout:
- Left column (weight 1): name (titleLarge), description (bodySmall,
max 2 lines, ellipsis) hidden when blank.
- Right column (minWidth 82dp, end-aligned): state tag — CompletedTag +
completedAt for Completed; IdlingTag for Idled.
Matches iOS ItemTagListCardView's HStack { VStack(alignment: .leading)
[name, description] | Spacer | VStack(alignment: .trailing) [tag,
completedAt] } shape.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop description block from ShopDetailCardView and revert to the flatter row layout. Restructure ItemTagListCardView from ListItem to a manual Row with a 2-column layout that surfaces the description. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror iOS ItemTagListCardView's 2-column HStack pattern in
ShopDetailCardViewso each item-tag row inShopDetailViewsurfaces the description alongside the name.Layout
weight = 1f): name (titleLarge), description (bodySmall, max 2 lines, ellipsis) — description hidden when blank.widthIn(min = 82.dp), end-aligned): state tag —CompletedTag+completedAtforCompleted;IdlingTagforIdled.Matches iOS
ItemTagListCardView'sHStack { VStack(alignment: .leading) [name, description] | Spacer | VStack(alignment: .trailing) [tag, completedAt] }shape.Test plan
./gradlew assembleDebug→ BUILD SUCCESSFUL./gradlew test→ BUILD SUCCESSFUL./gradlew spotlessCheck→ BUILD SUCCESSFUL./gradlew lint→ BUILD SUCCESSFUL🤖 Generated with Claude Code