Replace #if DEBUG print() with os.Logger for structured logging#22
Merged
Replace #if DEBUG print() with os.Logger for structured logging#22
Conversation
Make appLogger internal and replace all 6 #if DEBUG print() blocks with appLogger.debug(..., privacy: .private) calls. os.Logger.debug() messages are not persisted to disk and privacy: .private values are redacted unless a debugger is attached, making #if DEBUG guards unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appLoggerinternal (wasprivate) so it can be used across the codebase#if DEBUG print() #endifblocks withappLogger.debug(..., privacy: .private)callsimport osto files that now useappLoggerdirectlyFiles changed:
Logger.swift,LoginRepository.swift,SignUpRepository.swift,NFCManager.swift,KeychainStore.swift,Utility.swiftos.Logger.debug()messages are not persisted to disk and values markedprivacy: .privateare redacted unless a debugger is attached, making#if DEBUGguards unnecessary.Test plan
🤖 Generated with Claude Code