Skip to content

Fix typos in NFCManager and SessionController #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dadachi merged 1 commit into from
Mar 25, 2026
Merged

Fix typos in NFCManager and SessionController #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions NativeAppTemplate/NFCManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,24 +74,24 @@ extension NFCManager: NFCManagerProtocol {
internalScanResult = nil
internalIsScanResultChanged = false
nfcOperation = .read
startSesstion()
startSession()
}

func startReadingForTesting() async {
internalScanResult = nil
internalIsScanResultChangedForTesting = false
nfcOperation = .readForTesting
startSesstion()
startSession()
}

func startWriting(ndefMessage: NFCNDEFMessage, isLock: Bool) async {
nfcOperation = .write
userNdefMessage = ndefMessage
self.isLock = isLock
startSesstion()
startSession()
}

private func startSesstion() {
private func startSession() {
nfcSession = NFCNDEFReaderSession(delegate: self, queue: nil, invalidateAfterFirstRead: false)
nfcSession?.begin()
}
Expand Down
12 changes: 6 additions & 6 deletions NativeAppTemplate/Sessions/SessionController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ import Observation

Task {
do {
let prmissionsResponse = try await permissionsService.allPermissions()
let permissionsResponse = try await permissionsService.allPermissions()

// Check that we have a logged in user. Otherwise this is pointless
guard let shopkeeper = self.shopkeeper else { return }
Expand All @@ -172,12 +172,12 @@ import Observation
// Ensure loginRepository is aware, and hence the keychain is updated
try self.loginRepository.updateShopkeeper(shopkeeper: self.shopkeeper)

shouldUpdateApp = Int(Bundle.main.appBuild)! < prmissionsResponse.iosAppVersion
shouldUpdatePrivacy = prmissionsResponse.shouldUpdatePrivacy
shouldUpdateTerms = prmissionsResponse.shouldUpdateTerms
maximumQueueNumberLength = prmissionsResponse.maximumQueueNumberLength
shouldUpdateApp = Int(Bundle.main.appBuild)! < permissionsResponse.iosAppVersion
shouldUpdatePrivacy = permissionsResponse.shouldUpdatePrivacy
shouldUpdateTerms = permissionsResponse.shouldUpdateTerms
maximumQueueNumberLength = permissionsResponse.maximumQueueNumberLength

shopLimitCount = prmissionsResponse.shopLimitCount
shopLimitCount = permissionsResponse.shopLimitCount

didFetchPermissions = true
} catch {
Expand Down
Loading