Skip to content

Remove dead code and fix unused parameter in Event.refresh #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dadachi merged 2 commits into from
Mar 25, 2026
Merged

Remove dead code and fix unused parameter in Event.refresh #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc92392
Remove dead code and fix unused parameter in Event.refresh
dadachi Mar 25, 2026
324ad20
Fix data race warning when sending NFCNDEFMessage across isolation bo…
dadachi Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NativeAppTemplate/Logging/Logger.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ struct Event {
) -> Self {
.init(
source: "\(Source.self)",
action: "Refresh"
action: action
)
}

Expand Down
2 changes: 1 addition & 1 deletion NativeAppTemplate/NFCManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ protocol NFCManagerProtocol: Sendable {
func startReading() async
func startReadingForTesting() async

func startWriting(ndefMessage: sending NFCNDEFMessage, isLock: Bool) async
func startWriting(ndefMessage: NFCNDEFMessage, isLock: Bool) async
}

final class NFCManager: NSObject, ObservableObject, @unchecked Sendable {
Expand Down
5 changes: 1 addition & 4 deletions NativeAppTemplate/UI/App Root/AppTabView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ struct AppTabView<
@Environment(DataManager.self) private var dataManager
@Environment(TabViewModel.self) private var model
@State var navigationPathShops = NavigationPath()
@State var navigationPathStats = NavigationPath()
private let shopListView: () -> ShopListView
private let scanView: () -> ScanView
private let settingsView: () -> SettingsView
Expand Down Expand Up @@ -83,13 +82,11 @@ extension AppTabView: View {
.tint(.accent)
.onChange(of: sessionController.client) {
navigationPathShops = NavigationPath()
navigationPathStats = NavigationPath()
}
.onChange(of: sessionController.shouldPopToRootView) {
if sessionController.shouldPopToRootView {
navigationPathShops = NavigationPath()
navigationPathStats = NavigationPath()
sessionController.shouldPopToRootView = false
sessionController.shouldPopToRootView = false
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions NativeAppTemplate/UI/Shop Settings/ItemTag Detail/ItemTagDetailViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ final class ItemTagDetailViewModel {
return
}

let ndefMessage = createNdefMessage(itemTag: itemTag, itemTagType: .server)
nonisolated(unsafe) let ndefMessage = createNdefMessage(itemTag: itemTag, itemTagType: .server)

Task {
await nfcManager.startWriting(ndefMessage: ndefMessage, isLock: isLocked)
Expand All @@ -104,7 +104,7 @@ final class ItemTagDetailViewModel {
return
}

let ndefMessage = createNdefMessage(itemTag: itemTag, itemTagType: .customer)
nonisolated(unsafe) let ndefMessage = createNdefMessage(itemTag: itemTag, itemTagType: .customer)

Task {
await nfcManager.startWriting(ndefMessage: ndefMessage, isLock: isLocked)
Expand Down
Loading