Drop unused tags-scanned count and howToUse; tighten ItemTag labels#51
Merged
dadachi merged 1 commit intosubstrate-v2from Apr 28, 2026
Merged
Conversation
- Drop scannedItemTagsCount from Shop model, adapter, demo repo, and tests; remove the "tags scanned by customers" stat from ShopListCardView.
- Replace ShopDetailView "Learn More" link with a left-aligned shopDetailInstruction ("Swipe an item tag to change its status.").
- Swap the OnboardingView "How to use" link for the Support Website link; trim onboarding from 13 to 8 descriptions and drop unused String(localized:) wrap.
- Normalize ItemTag string keys: editTag/addTag/deleteTag/etc. -> editItemTag/addItemTag/deleteItemTag/etc.
- Drop unused constants: howToUseUrl, learnMore, createShops, createTags.
dadachi
deleted the
substrate-v2--drop-tags-scanned-tighten-itemtag-labels
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scannedItemTagsCountfromShopmodel, adapter, demo repo, and tests; remove the "tags scanned by customers" stat fromShopListCardView.ShopDetailView"Learn More" link with a left-alignedshopDetailInstruction("Swipe an item tag to change its status.").OnboardingView"How to use" link for the Support Website link; trim onboarding from 13 to 8 descriptions and drop unusedString(localized:)wrap.editTag/addTag/deleteTag/etc. →editItemTag/addItemTag/deleteItemTag/etc.howToUseUrl,learnMore,createShops,createTags.Ports https://github.com/nativeapptemplate/NativeAppTemplate-iOS/pull/61.
Test plan
make lintpassesShopDetailViewshows the new instruction text, left-alignedShopListCardViewno longer shows the scanned tags row