Wrap String constants in enum Strings namespace#52
Merged
dadachi merged 1 commit intosubstrate-v2from Apr 28, 2026
Merged
Conversation
Convert the large `extension String` block in `Constants.swift` to a caseless `enum Strings` namespace, matching the existing `NativeAppTemplateConstants` idiom in the same file. Inline the two `cardDateString`/`cardTimeString` literals in `DateFormatter+Extensions.swift` and remove the small extension they lived in. Update call sites across the app and tests from `String.foo` to `Strings.foo`, including dot-shorthand uses for `message:`, `text:`, `buttonTitle:`, and `?.message ==` parameters. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extension Stringblock inConstants.swiftto a caselessenum Stringsnamespace, matching the existingNativeAppTemplateConstantsidiom in the same file.cardDateString/cardTimeStringliterals inDateFormatter+Extensions.swiftand drop the small extension they lived in.String.footoStrings.foo, including dot-shorthand uses formessage:,text:,buttonTitle:, and?.message ==parameters.Mirrors upstream nativeapptemplate/NativeAppTemplate-iOS#62, adapted to this Free fork (which does not have the Account/Invitation surface and keeps the existing
image()/isAlphanumeric()Stringhelpers because tests still depend on them).Test plan
make lintpasses (SwiftLint + SwiftFormat, 0 violations)xcodebuild buildsucceeds for iPhone simulator (generic)xcodebuild testsucceeds on iPhone 17 simulator (all tests pass)Back to Start Screenbutton on permission error🤖 Generated with Claude Code