Add Pundit policies for controllers that skipped verify_authorized#24
Merged
Add Pundit policies for controllers that skipped verify_authorized#24
Conversation
Replace skip_after_action :verify_authorized and manual before_action auth checks with proper Pundit authorize calls in AccountsController, AccountsShopkeepersController, Accounts::AccountsInvitationsController, AccountsInvitationsController, MeController, and PasswordsController. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dadachi
changed the title
dadachi
deployed
to
add_pundit_policies_for_skipped_controllers - nativeapptemplateapi-cache PR #24
Render
Active
dadachi
deployed
to
add_pundit_policies_for_skipped_controllers - nativeapptemplateapi-queue PR #24
Render
Active
dadachi
deployed
to
add_pundit_policies_for_skipped_controllers - nativeapptemplateapi-cable PR #24
Render
Active
dadachi
deployed
to
add_pundit_policies_for_skipped_controllers - nativeapptemplateapi PR #24
Render
Active
dadachi
temporarily deployed
to
add_pundit_policies_for_skipped_controllers - nativeapptemplateapi PR #24
Render
Destroyed
dadachi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_after_action :verify_authorizedand manualbefore_actionauth checks with proper Punditauthorizecalls in 6 controllers:AccountsController,AccountsShopkeepersController,Accounts::AccountsInvitationsController,AccountsInvitationsController,MeController, andAccount::PasswordsControllerAccountPolicy,AccountsShopkeeperPolicy,AccountsInvitationPolicy,MePolicy,PasswordPolicy) with role-based authorization matching the existing manual checkspundit_userin account-scoped controllers to resolve the shopkeeper's role in the param-specified account (not the middleware account)AccountPolicyAccountsShopkeeperPolicyAccountsInvitationPolicyMePolicyPasswordPolicyTest plan
AccountsControllertests (1 → 8 tests) covering CRUD + auth checksAccountsInvitationsControllertests for cross-account access🤖 Generated with Claude Code