Fix nil pointer bugs in version lookups and permissions#27
Merged
Conversation
- AppVersion/PrivacyVersion/TermsVersion: .first.version crashes with NoMethodError when no matching record exists. Use safe navigation operator (&.) to return nil instead. - AppVersion: use `current` instead of `AppVersion.current` so chained scopes (e.g. forced_update.current_version) are preserved. - AccountsShopkeeper#permissions: simplify role-to-permissions lookup using active_roles.first with find_by! for clearer error on missing role data. - Add tests for nil-safety edge cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppVersion.current_version,PrivacyVersion.current_version,TermsVersion.current_version—.first.versioncrashes withNoMethodErrorwhen no matching record exists. Use&.versionfor nil safety.AppVersion.current_versionscope chaining —AppVersion.currentstarted a new query chain, losing any previously chained scopes (e.g.forced_update). Changed tocurrent(relative) so chained scopes are preserved.AccountsShopkeeper#permissions— replace 12-line if/elsif chain withactive_roles.first+find_by!for clearer code and better error on missing role data.Test plan
current_versionreturns nil when no records matchunforced_update.current_versionrespects chained scopepermissionsmethod🤖 Generated with Claude Code