Fix shopkeeper deletion FK violation on item_tags#38
Merged
Conversation
Shopkeeper deletion (DELETE /shopkeeper_auth) failed with ActiveRecord::InvalidForeignKey because item_tags had RESTRICT foreign keys on completed_by_id and created_by_id. Changed these 2 FK constraints to ON DELETE SET NULL at both DB and model level so item_tags are preserved with nullified shopkeeper references. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /shopkeeper_auth) failed withActiveRecord::InvalidForeignKeybecauseitem_tagshad RESTRICT foreign keys referencingshopkeepersviacompleted_by_idandcreated_by_idON DELETE SET NULLat both DB level (migration) and Rails level (dependent: :nullify) so item_tag records are preserved with nullified shopkeeper referencesTest plan
bin/cipassescompleted_by_id/created_by_idafter shopkeeper deletion🤖 Generated with Claude Code