Skip to content

Cleanup: Begin cameling fo the cases - Paths#4399

Open
dbolack-ab wants to merge 5 commits intonaturalcrit:masterfrom
dbolack-ab:issue_3352_part1
Open

Cleanup: Begin cameling fo the cases - Paths#4399
dbolack-ab wants to merge 5 commits intonaturalcrit:masterfrom
dbolack-ab:issue_3352_part1

Conversation

@dbolack-ab
Copy link
Copy Markdown
Collaborator

Description

This begins the renaming and referencing of files into camelCase. Due to some baked-in assumptions about theme pathing, there is a small bit of code rework.

Related Issues or Discussions

QA Instructions, Screenshots, Recordings

Should pass all tests, provide all snippets, and theme files.

Reviewer Checklist

*Reviewers, refer to this list when testing features, or suggest new items *

  • Identify opportunities for simplification and refactoring
  • Check for code legibility and appropriate comments

@dbolack-ab dbolack-ab added cleanup Cleaning up code for legibility, style, ease-of-use, etc. P2 - minor feature or not urgent Minor bugs or less-popular features 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed labels Aug 27, 2025
@5e-Cleric
Copy link
Copy Markdown
Member

Nice, this will conflict with everyone's work, haha (not that we could avoid it in any way)

@calculuschild calculuschild temporarily deployed to homebrewery-pr-4399 October 4, 2025 17:28 Inactive
Copy link
Copy Markdown
Member

@5e-Cleric 5e-Cleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, and since we aren't working with themes lately, i guess this could be merged, conflicts should be small if any.

will request other reviews.

@calculuschild
Copy link
Copy Markdown
Member

@dbolack-ab Do you want to reopen this one for hacktoberfest?

@G-Ambatte
Copy link
Copy Markdown
Collaborator

G-Ambatte commented Oct 5, 2025

From a raw functionality pass on the deployment:

Looks like the preview thumbnails are broken:
image

Attempting to select the Journal theme results in an error, and no Theme is applied:
image
image
image

Also, there are conflicts reported with the Unearthed Arcana theme that was merged to master a few weeks ago.


From the code that I looked at, the vast majority are location changes to match the new folder/file structure. I expect that when functionality is restored, the rest of the PR will proceed quickly.

@G-Ambatte G-Ambatte closed this Oct 5, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in @calculuschild's backlog Oct 5, 2025
@G-Ambatte
Copy link
Copy Markdown
Collaborator

Misclick.

@G-Ambatte G-Ambatte reopened this Oct 5, 2025
@github-project-automation github-project-automation bot moved this from Done to Backlog in @calculuschild's backlog Oct 5, 2025
@dbolack-ab
Copy link
Copy Markdown
Collaborator Author

@dbolack-ab Do you want to reopen this one for hacktoberfest?

I thought there might be too much chance for a breakage or something I missed, particularly with how many baked in assumptions there are about paths on themes.

@5e-Cleric
Copy link
Copy Markdown
Member

Btw, my congrats on what is the best possible name for this PR

@dbolack-ab
Copy link
Copy Markdown
Collaborator Author

@G-Ambatte The Unearthed Arcana should be testable now.

@5e-Cleric 5e-Cleric moved this from Backlog to Waiting for Calc's First Review in @calculuschild's backlog Nov 10, 2025
Copy link
Copy Markdown
Member

@5e-Cleric 5e-Cleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic, Looks ready to me, just renames and a helper moved to helpers file.

@5e-Cleric 5e-Cleric moved this from Waiting for Calc's First Review to Pushing to Finish in @calculuschild's backlog Jan 3, 2026
@dbolack-ab dbolack-ab added the Orphan This project's original dev is not going to finish this, feel free to pick it up label Mar 14, 2026
@5e-Cleric 5e-Cleric added 🔍 R3 - Reviewed - Awaiting Fixes 🔧 PR is okayed but needs fixes before merging and removed 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed labels Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Cleaning up code for legibility, style, ease-of-use, etc. Orphan This project's original dev is not going to finish this, feel free to pick it up P2 - minor feature or not urgent Minor bugs or less-popular features 🔍 R3 - Reviewed - Awaiting Fixes 🔧 PR is okayed but needs fixes before merging

Projects

Status: Pushing to Finish

Development

Successfully merging this pull request may close these issues.

5 participants