Migrate to Marked-mustache in markdown.js instead of inlined code for {} and {{}} markdown extensions#4444
Open
dbolack-ab wants to merge 7 commits intonaturalcrit:masterfrom
Open
Migrate to Marked-mustache in markdown.js instead of inlined code for {} and {{}} markdown extensions#4444dbolack-ab wants to merge 7 commits intonaturalcrit:masterfrom
dbolack-ab wants to merge 7 commits intonaturalcrit:masterfrom
Conversation
dbolack-ab
added
cleanup
dbolack-ab
changed the title
Collaborator
Author
5e-Cleric
moved this from Backlog
to Waiting for Calc's First Review
in @calculuschild's backlog
Member
|
Everything seems to work, can you fix the conflicts so i can approve this and merge? |
5e-Cleric
added
🔍 R3 - Reviewed - Awaiting Fixes 🔧
5e-Cleric
moved this from Waiting for Calc's First Review
to Under Review
in @calculuschild's backlog
Member
|
@5e-Cleric the external package itself needs some tweaks (and accompanying version bump) before this can merge |
Collaborator
Author
marked-modules-transitional/marked-mustache#1 should take care of this. |
Member
|
Will close #4035 |
12 tasks
dbolack-ab
added
the
Orphan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the mustache extensions from markdown.js to their own npm module.
Make sure the migrated code is up to date in the module before merging!
Related Issues or Discussions
#4035
Reviewer Checklist
*Reviewers, refer to this list when testing features, or suggest new items *