Add data-lineNumbers attribute to <p> element#2
Open
dbolack-ab wants to merge 3 commits intonaturalcrit:mainfrom
Open
Add data-lineNumbers attribute to <p> element#2dbolack-ab wants to merge 3 commits intonaturalcrit:mainfrom
dbolack-ab wants to merge 3 commits intonaturalcrit:mainfrom
Conversation
Add testing for position on token to set data-lineNumber Update marked version range to minimum to support marked-token-position
This reverts commit c13933e.
Member
|
I can see the intent here, though I can't help but think there must be a way to do it without requiring a change to every extension and every renderer. Can we pause this PR and try to find a more general solution we could just load alongside all the other extensions? I don't have a perfect solution in mind, but it feels like we should be able to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add testing for position on token to set data-lineNumber Update marked version range to minimum to support marked-token-position