Rework for supporting ESP-IDF 5 and Catch2 v3#1
Open
5p4k wants to merge 4 commits intonatureglobal:mainfrom
Open
Rework for supporting ESP-IDF 5 and Catch2 v3#15p4k wants to merge 4 commits intonatureglobal:mainfrom
5p4k wants to merge 4 commits intonatureglobal:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of Catch2 has a compiled component. This means that
-Wl,--whole-archiveoption (which is now available as an option ofidf_component_registeras well)--whole-archiveonly on the tests.ESP-IDF as well got updated, and now starting from version 4 there is no more legacy makefile support, so I removed that; stack size also had to be increased a little more.
The options
CATCH_CONFIG_NO_POSIX_SIGNALSandCATCH_CONFIG_DISABLE_EXCEPTIONSare still necessary, so I created a wrapping header that sets them before includingcatch_amalgamated.hpp(they also had to be set as compile flags).