Skip to content
This repository was archived by the owner on Nov 5, 2022. It is now read-only.

Feature/multi select#1

Open
nihenlang wants to merge 16 commits intodevfrom
feature/multi-select
Open

Feature/multi select#1
nihenlang wants to merge 16 commits intodevfrom
feature/multi-select

Conversation

@nihenlang
Copy link

@nihenlang nihenlang commented Dec 25, 2020

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

Copy link

@btspoony btspoony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不多写了,整体的实现思路就有问题。
这些特性化的样式,应该添加一个新的变量来进行控制(对于 css 来说就是一个额外的平级 class)
如果修改全局的样式将对原有内容产生不可预知的改动。

background-color: mix($--tag-info-color, $--color-white, $backgroundColorWeight);
border-color: mix($--tag-info-color, $--color-white, $borderColorWeight);
color: mix($--tag-info-color, $--color-white, $fontColorWeight);
background-color: $--cascader-tag-background-opacity;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag 不能修改全局的,没出问题是因为我们的项目中有所复写。
本质上这样将特定的需求改在全局的内容是非常不合适的。

// color: mix($--tag-info-color, $--color-white, $fontColorWeight);
color: $--custom-color-primary;
background-color: unset;
font-weight: 900;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在全局 tag 上修改 font-weight 不合适

&:hover {
color: $--color-white;
background-color: mix($--tag-info-color, $--color-white, $hoverColorWeight);
background-color: unset;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么是 unset?这里是全局的 tag

@@ -15,6 +15,9 @@ $--color-transition-base: color .2s cubic-bezier(.645,.045,.355,1) !default;

/* Color
-------------------------- */
// custom Color
$--custom-color-primary: #898eff !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个值可以通过外面覆盖 $--color-primary,不需要额外添加,在需要的地方使用 $--color-primary即可

@@ -32,14 +32,16 @@
.el-icon-arrow-down {
transition: transform .3s;
font-size: 14px;
font-weight: 900;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同理,font-weight 在这里修改不合适

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants