Skip to content

Conversation

@mdorf
Copy link
Member

@mdorf mdorf commented Sep 17, 2025

The SPARQL Client query method accepts an optional parameter, :bypass_cache => true|false:

https://github.com/ncbo/sparql-client/blob/master/lib/sparql/client.rb#L279

However, that parameter, even when passed by the higher API calls, gets muted and never makes it to the SPARQL Client layer. This change allows this parameter to propagate to the query method of the SPARQL Client.

For example:

ont = Ontology.find(params["acronym"], bypass_cache: true).include(:acronym, :administeredBy, :acl, :viewingRestriction, submissions: :submissionId).first

@mdorf mdorf changed the title Allow the :bypass_cache param to propogate from the GOO to sparql-client Allow the :bypass_cache param to propogate from GOO to sparql-client Sep 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.74%. Comparing base (ca5f9d8) to head (85517f3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #170   +/-   ##
========================================
  Coverage    87.73%   87.74%           
========================================
  Files           39       39           
  Lines         2748     2749    +1     
========================================
+ Hits          2411     2412    +1     
  Misses         337      337           
Flag Coverage Δ
unittests 87.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdorf mdorf changed the title Allow the :bypass_cache param to propogate from GOO to sparql-client Allow the :bypass_cache param to propogate from GOO to sparql-client Sep 17, 2025
@mdorf mdorf changed the title Allow the :bypass_cache param to propogate from GOO to sparql-client Allow the :bypass_cache param to propagate from GOO to sparql-client Sep 18, 2025
@alexskr alexskr merged commit b92ae7a into develop Sep 23, 2025
8 checks passed
mdorf added a commit that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants