This repository was archived by the owner on Sep 4, 2025. It is now read-only.
fix: add PR context check to prevent undefined ref error#514
Merged
aditigopalan merged 1 commit intomainfrom Apr 22, 2025
Merged
fix: add PR context check to prevent undefined ref error#514aditigopalan merged 1 commit intomainfrom
aditigopalan merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an error in the JSON-LD conversion workflow by adding a PR context check so that PR-specific steps are only executed when applicable.
- Introduces a condition to set and check the PR context.
- Conditionally executes the pr-fetch and pr-push steps.
- Prevents the workflow from attempting PR operations during manual or release events.
Comments suppressed due to low confidence (2)
.github/workflows/ci-lint-validate-convert.yml:89
- [nitpick] Consider renaming the step id 'check_pr' to a more descriptive identifier such as 'pr_context_check' to improve readability.
- name: Check if in PR context
.github/workflows/ci-lint-validate-convert.yml:109
- [nitpick] Ensure consistency in naming by using the same descriptive identifier for conditional steps across the workflow.
- name: Push changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the JSON-LD conversion workflow where the action was failing with the error "Cannot read properties of undefined (reading 'ref')" when triggered manually or by a release event.
Changes
Testing
Fixes #509