-
Notifications
You must be signed in to change notification settings - Fork 65
Dev #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Dev #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add callout pointing to NNsight.md for technical deep dive - Update 'More Examples' to 'More Resources' with doc links - ci: limit pytest to test_lm.py and test_tiny.py
- Add Envoy subsections 4.8-4.11 to TOC - Add Debugging subsections 7.1-7.8 to TOC - Add Remote Execution subsections 8.1-8.12 to TOC - Remove 'coming soon' from sections 7 and 8 - Update README link text per user feedback
…ty and focus - Revamped section titles and descriptions to better reflect the library's capabilities. - Enhanced explanations of the `nnsight` library's access to neural network internals. - Emphasized the importance of community collaboration in advancing AI research. - Improved overall structure and readability of the notebook.
- Improved formatting and alignment of user code examples for better readability. - Clarified descriptions of the VLLM Class and NNsightGPUModelRunner functionalities. - Added detailed flow of data and interactions between components in the NNsight architecture. - Ensured consistent presentation of intervention code and its role in the processing pipeline.
Removed note saying that using .source recursively is not allowed.
…logger - Introduced a new status display system for job execution, enhancing user feedback with color-coded status updates and spinners. - Removed the previous remote logger implementation, streamlining logging functionality. - Updated response logging to utilize the new status display for better formatting and clarity. - Adjusted related components to ensure compatibility with the new logging approach.
- Changed API host in config.yaml and related files to use HTTPS for improved security. - Removed redundant SSL handling in the RemoteBackend class, deriving websocket protocol from the HTTP protocol. - Ensured consistent handling of API key and host configuration across the application.
Delete note on iterative .source access in NNsight.md
- Removed the log.py file and integrated the job status display functionality directly into the remote backend. - Enhanced the status display with support for terminal and notebook environments, including color-coded updates and spinners. - Updated response handling to utilize the new status display system for improved user feedback during job execution. - Streamlined the logging process by eliminating the previous remote logger implementation.
- Updated the JobStatusDisplay class to store the last response, allowing for automatic refresh of job status when no new data is provided. - Modified the update method to handle optional parameters, improving flexibility in status updates. - Streamlined the RemoteBackend class to utilize the new update mechanism for refreshing status displays during timeout events.
- Replaced the notebook display ID with a DisplayHandle for improved flicker-free updates in the JobStatusDisplay class. - Simplified the display logic to utilize the new DisplayHandle, enhancing the clarity and maintainability of the code. - Ensured proper reset of the display handle after job completion for better state management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.