Skip to content

Add optional mapId config for GeoJsonFolder #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MisterGC wants to merge 1 commit into
base: fix/140-withAttrLayers-default
Choose a base branch
from
Open

Add optional mapId config for GeoJsonFolder #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion libs/http-service/src/cli.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ nlohmann::json geoJsonFolderSchema()
{"title", "Folder"},
{"description", "Path to a folder containing GeoJSON tiles."}
}},
{"mapId", {
{"type", "string"},
{"title", "Map ID"},
{"description", "Custom map identifier. If not provided, derived from folder path."}
}},
{"withAttrLayers", {
{"type", "boolean"},
{"title", "With Attribute Layers"},
Expand Down Expand Up @@ -238,7 +243,10 @@ void registerDefaultDatasourceTypes() {
bool withAttributeLayers = true;
if (auto withAttributeLayersNode = config["withAttrLayers"])
withAttributeLayers = withAttributeLayersNode.as<bool>();
return std::make_shared<geojsonsource::GeoJsonSource>(folder.as<std::string>(), withAttributeLayers);
std::string mapId;
if (auto mapIdNode = config["mapId"])
mapId = mapIdNode.as<std::string>();
return std::make_shared<geojsonsource::GeoJsonSource>(folder.as<std::string>(), withAttributeLayers, mapId);
}
throw std::runtime_error("Missing `folder` field.");
},
Expand Down
Loading