Open
Conversation
pskeshu
requested review from
abhirathb and
theblackfly
and removed request for
abhirathb and
theblackfly
Contributor
Author
|
requesting review @abhirathb |
theblackfly
requested changes
Apr 16, 2021
Contributor
theblackfly
left a comment
theblackfly
left a comment
There was a problem hiding this comment.
- Sort imports with
isort. labels_ = np.array([seg_func(img) for img in image])is a one liner.- If
imageis an array of images, you should perhaps call itimagesin plural instead.
pskeshu
commented
Apr 16, 2021
Contributor
Author
pskeshu
left a comment
pskeshu
left a comment
There was a problem hiding this comment.
1. Sort imports with `isort`. 2. `labels_ = np.array([seg_func(img) for img in image])` is a one liner. 3. If `image` is an array of images, you should perhaps call it `images` in plural instead.
regarding 3., the variable image can be n-dimensional. so not sure whether to call it singular or plural.
| RE.subscribe(bec) | ||
| RE.subscribe(db.insert) | ||
|
|
||
| class Microscope: |
Contributor
Author
There was a problem hiding this comment.
this is a work in progress, where the Microscope will be constantly redefined in a higher level. This will be the API for the user.
pskeshu
commented
Apr 16, 2021
Contributor
Author
pskeshu
left a comment
pskeshu
left a comment
There was a problem hiding this comment.
I have made the changes you requested.
Contributor
|
@pskeshu code doesn't have any comments. Please add some comments |
…ents for some others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.