-
Notifications
You must be signed in to change notification settings - Fork 5
ci: add plugin manifest linting #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
04813b7
ci: add codex-plugin-scanner quality gate
internet-dot 356dc7e
ci: pin actions to SHAs, add permissions, timeout, concurrency
internet-dot d7d292f
ci:enforce-plugin-scanner-minimum-score
ndycode 9eb8e41
ci:clarify-scanner-root-and-namespace-concurrency
ndycode 88d73c8
ci:add-manual-plugin-scanner-trigger
ndycode 2324daf
ci: harden plugin scanner coverage
ndycode 09230d1
ci: tighten plugin scanner regression coverage
ndycode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "codex-multi-auth", | ||
| "version": "1.2.1", | ||
| "version": "1.2.2", | ||
| "description": "Install and operate codex-multi-auth for the official @openai/codex CLI with multi-account OAuth rotation, switching, health checks, and recovery tools.", | ||
| "skills": "./skills/" | ||
| } |
4 changes: 4 additions & 0 deletions
4
.github/plugin-scanner-fixtures/bad/.codex-plugin/plugin.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "Fixture Bad Plugin", | ||
| "description": "Fixture plugin used to validate failing scanner behavior." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Fixture Bad Plugin | ||
|
|
||
| This fixture is expected to fail the plugin scanner quality gate. |
11 changes: 11 additions & 0 deletions
11
.github/plugin-scanner-fixtures/good/.codex-plugin/plugin.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "name": "fixture-good-plugin", | ||
| "version": "1.0.0", | ||
| "description": "Fixture plugin used to validate the Codex plugin scanner workflow.", | ||
| "author": "ndycode", | ||
| "homepage": "https://example.com/fixture-good-plugin", | ||
| "repository": "https://example.com/fixture-good-plugin.git", | ||
| "license": "MIT", | ||
| "keywords": ["fixture", "codex", "plugin"], | ||
| "skills": "./skills/" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # Fixture file for scanner regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| MIT License | ||
|
|
||
| Copyright (c) 2026 ndycode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Fixture Good Plugin | ||
|
|
||
| This fixture is expected to pass the plugin scanner quality gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Security Policy | ||
|
|
||
| Report security issues to fixture@example.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| name: example | ||
| description: Example fixture skill for scanner regression coverage. | ||
| --- | ||
|
|
||
| # Example | ||
|
|
||
| This fixture skill exists to satisfy the plugin scanner regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| name: Codex Plugin Quality Gate | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| scan: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 10 | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| - name: Codex plugin scanner | ||
| uses: hashgraph-online/hol-codex-plugin-scanner-action@b45d6b583afe05819b24edc8e6418c9ad2e1f1d0 # v1 | ||
| with: | ||
greptile-apps[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # The pinned action resolves .codex-plugin/plugin.json from the repo root. | ||
| plugin_dir: "." | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| min_score: "70" | ||
greptile-apps[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| scan-regression: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-latest | ||
| fixture: good | ||
| plugin_dir: ".github/plugin-scanner-fixtures/good" | ||
| expect_outcome: success | ||
| - os: ubuntu-latest | ||
| fixture: bad | ||
| plugin_dir: ".github/plugin-scanner-fixtures/bad" | ||
| expect_outcome: failure | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - os: windows-latest | ||
| fixture: good | ||
| plugin_dir: ".github/plugin-scanner-fixtures/good" | ||
| expect_outcome: success | ||
| - os: windows-latest | ||
| fixture: bad | ||
| plugin_dir: ".github/plugin-scanner-fixtures/bad" | ||
| expect_outcome: failure | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 10 | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| - name: Codex plugin scanner regression | ||
| id: scan | ||
| continue-on-error: true | ||
| uses: hashgraph-online/hol-codex-plugin-scanner-action@b45d6b583afe05819b24edc8e6418c9ad2e1f1d0 # v1 | ||
| with: | ||
| plugin_dir: ${{ matrix.plugin_dir }} | ||
| min_score: "70" | ||
| - name: Assert fixture outcome | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ steps.scan.outcome }}" != "${{ matrix.expect_outcome }}" ]; then | ||
| echo "Expected fixture '${{ matrix.fixture }}' to '${{ matrix.expect_outcome }}', got '${{ steps.scan.outcome }}'." | ||
| exit 1 | ||
| fi | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.