Conversation
|
@emanspeaks I'm reviewing your changes and it seems you had troubles with CPM. Could you open an issue, either here on at CPM, and I'll try to solve it. |
|
The main problem I was trying to solve with this PR was ultimately that there are slight syntactic differences between C++17 and C++20, neither of which MSVC enforces quite as strictly as Clang, so I was seeking a way to make code that would compile with both standards in both MSVC and Clang. Those changes are actually rather minor. But testing the library turned out to be highly problematic: first trying to get it to build and run the tests and sample code locally and then, later, in the Actions workflow here once I created the PR. Furthermore, because I wanted to include this in my library using CMake FetchContent, I had a lot of issues also getting it to fetch utpp and, furthermore, lots of issues with differences in language standards between THOSE libraries. CMake was struggling with having it put the I am aware all of this sort of goes against the spirit of what you're trying to do with the current CPM config, so my hope was to first get this PR to pass the tests for the original problem of the core library code and handling language/compiler discrepancies, and then figured we can discuss if you're ok with this change or if you want to iterate on this and/or CPM (or I wrote an issue for CPM and linked to this PR. As described above, the issue there was having CPM not providing an easy way to test changes on any branch, commit, or repo that was not the main branch of your copy of the repo, which makes it otherwise impossible to test or accept PRs from other users, something I don't think you intended 😄 |
This PR presents numerous changes throughout the project to be more compatible with clang, which I have recently begun to use for my new project and encountered many issues using this library. Also various fixes and formatting adjustments to documentation.