Adding OpenMCCellTransform

[meltawila]

closes #1255

[moosebuild]

Job Documentation, step Sync to remote on 7ef0664 wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Test nekRS on 5a186ff : invalidated by @meltawila

[moosebuild]

Job Coverage, step Generate coverage on 7ef0664 wanted to post the following:

Coverage

	06d42a	#1256 7ef066
	Total	Total	+/-	New
Rate	93.08%	93.08%	-0.00%	100.00%
Hits	9378	9430	+52	56
Misses	697	701	+4	0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

[aprilnovak]

Since @lewisgross1296 is planning to use cell rotations, how about we generalize this object so that it does both translations and rotations? I'm thinking in line of the TransformGenerator mesh generator which does both translations and rotations. The input syntax could be something like

type = OpenMCCellTransform
transform_type = rotation # or translation
vector_value = 'pp_x pp_y pp_z'

[aprilnovak]

do these symbols show up correctly in the documentation when compiled? also it may be clearer to say rotation angles about x, y, z because not everyone is consistent about these symbols

[lewisgross1296]

I think this follows the notation listed in the openmc.Cell documentation. I agree that there's so many different versions of which angles are rotating about which axis over internet and textbooks, so it might be clearer to call them rot_x rot_y and rot_z? At the very least, we should reference the openmc.Cell documentation and make sure it's consistent with it

[meltawila]

The symbols show up correctly in the documentation, and yes I wanted to be consistent with OpenMC documentation but lmk if you prefer otherwise. The "the rotation angles in degrees about x, y, and z axes." description is already in docs. under example input syntax.

https://mooseframework.inl.gov/cardinal/docs/PRs/1256/site/source/userobjects/OpenMCCellTransform.html

[lewisgross1296]

I think this follows the notation listed in the openmc.Cell documentation. I agree that there's so many different versions of which angles are rotating about which axis over internet and textbooks, so it might be clearer to call them rot_x rot_y and rot_z? At the very least, we should reference the openmc.Cell documentation and make sure it's consistent with it

[meltawila]

The VTB test failure is unrelated

[moosebuild]

Job Test VTB on f8908b8 : invalidated by @meltawila

[lewisgross1296]

Nothing major, just some more thoughts I had

[moosebuild]

Job Precheck, step Clang format on a3af5f8 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/1256/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 548ceb7393a15cd970aeed75cf8805df38212c99