NEBULA-3609 document the code paths for spring boot 1 and 3 better #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more test cases to cover spring boot 2 and multiple gradle versions Add toolchain configuration to ensure consistent jdk version usage for compile/testing improve the reaction to spring boot plugin to move closer to gradle best practices
wakingrufus
commented
Jul 30, 2025
|
|
||
| java { | ||
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(17) |
Member
Author
There was a problem hiding this comment.
compile on 17, instead of daemon version (21)
wakingrufus
commented
Jul 30, 2025
| } else { | ||
| archiveClassifier = 'boot' | ||
| } | ||
| project.plugins.withId("org.springframework.boot") { |
Member
Author
There was a problem hiding this comment.
withId allows the plugins to be listed in any order, and this block will always execute after the spring boot plugin is applied
Member
Author
There was a problem hiding this comment.
most of the rest of this diff is just from the extra indentation... it looks like much more than it actually is
| createStartScripts.mainClassName = 'org.springframework.boot.loader.JarLauncher' | ||
| } | ||
| } else { | ||
| project.logger.info("Spring Boot 1 detected") |
Member
There was a problem hiding this comment.
👍 helpful logging indeed, especially for this much older and thus unexpected version
| def mainClass = project.objects.property(String) | ||
| try { | ||
| mainClass.set(project.application.mainClass.isPresent() ? project.application.mainClass.get() : project.application.mainClassName) | ||
| mainClass.set(project.springBoot.mainClass) |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
the diff is deceiving here. this code has not changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more test cases to cover spring boot 2 and multiple gradle versions Add toolchain configuration to ensure consistent jdk version usage for compile/testing improve the reaction to spring boot plugin to move closer to gradle best practices