Add Gradle plugin rules for lazy configuration, service injection, and extension best practices

[rpalcolea]

New Rules Added

Task Container API Rules

• USE_NAMED_INSTEAD_OF_GET_BY_NAME: Enforces lazy task lookup using tasks.named() instead of tasks.getByName()
• USE_CONFIGURE_EACH_INSTEAD_OF_ALL: Enforces lazy task configuration using configureEach() instead of all()

Service Injection Rules

• USE_INJECTED_OBJECT_FACTORY: Plugins should inject ObjectFactory via constructor instead of calling project.getObjects()
• USE_INJECTED_PROVIDER_FACTORY: Plugins should inject ProviderFactory via constructor instead of calling project.getProviders()

Provider API Rules

• PROVIDER_PROPERTIES: Task input/output properties should use Provider API types (Property, RegularFileProperty, DirectoryProperty, etc.)
• ABSTRACT_GETTERS: Task property getters returning Provider API types should be abstract
• EXTENSION_PROPERTIES_USE_PROVIDER_API: Extension properties should use Provider API types for lazy configuration
• EXTENSION_ABSTRACT_GETTERS: Extension property getters returning Provider API types should be abstract

Project Reference Rule

• PLUGINS_SHOULD_NOT_STORE_PROJECT_REFERENCES: Plugins should not store Project instances as fields (breaks configuration cache)

Refactoring

• Created TypeConstants.java to consolidate 32+ duplicate constant declarations across 5 files
• Added reusable predicate helpers: isProviderApiType(), callsMethodOn(), callsMethodOnAny()

[OdysseusLives]

🎉

[wakingrufus]

this seems kind of handwavy... maybe there is a way to find classes that are called as an arg to ExtensionsContainer.create?

[rpalcolea]

I was thinking about that. Need to dig deeper but wondering if I can look at the plugin class that creates the extension and then find the extension code but that seems like crossing boundaries in an archrule from what I understand so far, I'll think more about this one

[rpalcolea]

actually,

I think I'll use getAccessesToSelf and see if it is accessed from a plugin. I think that will add an extra level of certainty

[rpalcolea]

94d68cf improves things a bit.

I don't think I can detect project.extensions.create("greeting", GreetingExtension::class.java) easily 🤔

[wakingrufus]

this condition should probably be more in the shape of "fields declared in classes that (logic) should use provider api" and then the same for methods()

[rpalcolea]

addressed by 66252c2

[wakingrufus]

this condition can be more like "fields declared in classes that implement plugin should not have type of Project"

[rpalcolea]

Done in 9cd1673

[rpalcolea]

This is ready for review again @OdysseusLives @wakingrufus